Code review comment for lp:~aauzi/midori/bookmarks-work

Hi Dan,

> I think for the .po files, you can probably just delete any of them that
> aren't in the po directory and we'll know there's something really wrong if
> they regenerate :p

it's OK on my side, no more .po after deletion and clean build.

> After your latest commit, the branch does build with Gtk 3.4 :) But I'm afraid
> there are issues >.<

Great news! and issues were expected, it's all the point of testing and reviews, isn't it?

> I do have a problem that I can't access any bookmarks that are in a folder.
> Clicking the expander triangle does nothing. Double-clicking the folder
> expands, but as soon as I move the cursor it starts a drag operation.

OK, I believe the ugly trick used to keep the multi selection before dragging does not integrate well with Gtk 3. I'll work on that.

> Dragging any bookmarks in the sidepanel forces the Bookmarks Bar to open.

Oups! Now I have to see how we hide the bookmark bar. I'll work on that too.

> I think for the statusbar feature, it should probably only show on hover as is
> the behavior with links in the web view (but it is a cool feature!)

Sounds good, I will have a look on the web view and see how I can reproduce the behaviour.

Thanks for the valuable feedback.