Code review comment for lp:~aauzi/midori/bookmarks-work

Revision history for this message
Danielle Foré (danrabbit) wrote :

Hey André,

I think for the .po files, you can probably just delete any of them that aren't in the po directory and we'll know there's something really wrong if they regenerate :p

After your latest commit, the branch does build with Gtk 3.4 :) But I'm afraid there are issues >.<

I do have a problem that I can't access any bookmarks that are in a folder. Clicking the expander triangle does nothing. Double-clicking the folder expands, but as soon as I move the cursor it starts a drag operation.

Dragging any bookmarks in the sidepanel forces the Bookmarks Bar to open.

I think for the statusbar feature, it should probably only show on hover as is the behavior with links in the web view (but it is a cool feature!)

review: Needs Fixing

« Back to merge proposal