Code review comment for lp:~aaronp/software-center/review-refactor

Revision history for this message
Michael Vogt (mvo) wrote :

Hey Aaron, thanks a lot for your work on this!

I think this is good, there is just one issue with the tests
that probably just needs updating:
$ PYTHONPATH=. python tests/gtk3/test_appdetailsview.py
...
======================================================================
ERROR: test_all_duplicate_reviews_keeps_going (__main__.TestAppdetailsView)
AppDetailsView._reviews_ready_callback will fetch another page if
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1224, in patched
    return func(*args, **keywargs)
  File "tests/gtk3/test_appdetailsview.py", line 240, in test_all_duplicate_reviews_keeps_going
    application, callback = mock_get_reviews.call_args[0]
ValueError: need more than 1 value to unpack

======================================================================
ERROR: test_no_reviews_returned_attempts_relaxing (__main__.TestAppdetailsView)
AppDetailsView._reviews_ready_callback will attempt to drop the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mock.py", line 1224, in patched
    return func(*args, **keywargs)
  File "tests/gtk3/test_appdetailsview.py", line 206, in test_no_reviews_returned_attempts_relaxing
    application, callback = mock_get_reviews.call_args[0]
ValueError: need more than 1 value to unpack

----------------------------------------------------------------------
Ran 23 tests in 135.414s

I will try to get to it later today unless you want to tackle it (which would be very welcome
of course as well :)

« Back to merge proposal