Code review comment for lp:~aaronp/software-center/fix-794060-for-4.0

Revision history for this message
Michael Vogt (mvo) wrote :

On Fri, Jun 10, 2011 at 01:38:36PM -0000, Aaron Peachey wrote:
> Aaron Peachey has proposed merging lp:~aaronp/software-center/fix-794060-for-4.0 into lp:software-center/4.0.
>
> Requested reviews:
> software-store-developers (software-store-developers)
> Related bugs:
> Bug #794060 in software-center (Ubuntu): "Software Centre duplicate reviews"
> https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/794060
>
> For more details, see:
> https://code.launchpad.net/~aaronp/software-center/fix-794060-for-4.0/+merge/64183
>
> Fixes lp:#794060 which was resulting in review duplication after a review activity (e.g. submit usefulness) as pagination code introduced in 4.0.3 no longer clears the reviews in the app details view before reloading them.
>
> Once (and if) this branch is approved, I'll re-write the fix separately for trunk too (since the refactoring has changed alot of the structure in trunk since 4.0).
[..]

Indeed, thanks a lot for this! This is a good catch. I merged it now
and will push it to proposed next.

Thanks,
 Michael

« Back to merge proposal