On Tue, Mar 15, 2011 at 1:47 PM, Aaron Peachey <email address hidden> wrote:
> I'm re-thinking the patch now. Is this a better way?
>
Yeah, this one is nicer... thanks, although your test should show (I think?)
that you've left get_string in there - but I'll remove that when running it
before landing.
With the changes to the actual branch, can you pls revert the changes to
config/main.cfg . A great way for your next branch (/me hopes :) ), is to
add a django_project/local.cfg with just the customisations you need - this
will overwrite anything in main.cfg, and won't get committed.
The rest looks great! Thanks for being the first community contributor :)
Once you revert the main.cfg, I'll land the patch to rnrclient and then this
branch.
Hey again Aaron!
On Tue, Mar 15, 2011 at 1:47 PM, Aaron Peachey <email address hidden> wrote:
> I'm re-thinking the patch now. Is this a better way?
>
Yeah, this one is nicer... thanks, although your test should show (I think?)
that you've left get_string in there - but I'll remove that when running it
before landing.
With the changes to the actual branch, can you pls revert the changes to project/ local.cfg with just the customisations you need - this
config/main.cfg . A great way for your next branch (/me hopes :) ), is to
add a django_
will overwrite anything in main.cfg, and won't get committed.
The rest looks great! Thanks for being the first community contributor :)
Once you revert the main.cfg, I'll land the patch to rnrclient and then this
branch.
-Michael