Code review comment for lp:~aaronhoneycutt/ubiquity-slideshow-ubuntu/artful3

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

There are multiple issues with the proposed changes; I've attempted to fix them locally, but the response a few weeks ago was that it didn't look better (although test-slideshow looks a lot better to me after applying this -- fixes some spacing issues and text size, etc.). A lot of the changes are basically in the CSS, rather than the html

My proposed changes I have saved here: http://paste.ubuntu.com/25326881/

In the meantime, I'm merging this MP mostly as-is, fixing the issues found: multiple tags that are wrong or unclosed:

- img tags need a closing / at the end
- same for br, but br is usually better not used at all
- don't need a body or title, this is html but not a complete html document.

review: Approve

« Back to merge proposal