Code review comment for lp:~aaron-whitehouse/duplicity/filelist_combine
Revision history for this message
| edso (ed.so) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
three point
1. wouldn't it make sense to either depreciate in-/exclude or in/exclude-globbing as they afre functional identical
2. not sure if we should want to have keep the old non-globbing selection for simple setups. easier to understand and done.
3. your branch clashes with the current dev branch. you probably need to rebase your changes.
..ede/duply.net