Code review comment for lp:~aacid/unity8/verticalJournal

Revision history for this message
Albert Astals Cid (aacid) wrote :

> ----------------------------
>
> Any particular reason why you're calling m_columnVisibleItems.resize(nColumns)
> in componentComplete() right before calling polish()? Because updatePolish()
> already does the very same thing. Looks like this is either a redundant
> leftover that should be removed or a workaround for some obscure behavior
> which should then be explained with a comment (for the unware developer
> reading this code, like myself).

I'm voting leftover since can't think of any other reason.

« Back to merge proposal