Code review comment for lp:~aacid/unity8/verticalJournal

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

> > Change name from testverticaljournal to testVerticalJournal
> > The reviewer thinks that it is better to addhere to the global rules than to
> the folder rules
>
> If there are other tests in this directory which have all-lowercase targets
> ("testfoo") they should also be updated as well (to the "testFoo" way). But
> not in this merge proposal, naturally.

The reasoning being that, when you want to test a single component/class in unity8, you go to the terminal and write (from its build dir):
$ make testComponentName
Likewise when you want to manually test some component:
$ make tryComponentName

That way you only have to know the name of the component. If the make targets don't follow any convention the poor developer will have to dig into the relevent CMakeLists.txt to find out how to summon the desired test.

« Back to merge proposal