Code review comment for lp:~aacid/unity8/use_sdk_13

Revision history for this message
Mirco Müller (macslow) wrote :

Code looks ok.

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

Ran on mako and everything looked ok. My krillin is dead atm.

Checked the SDK-test by injecting a wrong import using 1.2 and it was correctly caught by the script.

* Did CI run pass? If not, please explain why.
No, because multiple autopilot errors occurred due to unity8 process probably crashing -> "psutil.NoSuchProcess: no process found with pid..."

ERROR: unity8.greeter.tests.test_args.GreeterArgsTest.test_shell_mode
ERROR: unity8.shell.tests.test_helpers.DashHelperTestCase.test_open_scope_to_the_right(Nexus 4)
ERROR: unity8.indicators.tests.test_display_indicator.DisplayIndicatorTestCase.test_indicator_icon_must_not_be_visible_after_rotation_unlocked(Nexus 4)
ERROR: unity8.shell.tests.test_helpers.GenericScopeViewHelperTestCase.test_open_preview(Nexus 4)
ERROR: unity8.indicators.tests.test_action_latency.TestServerValueUpdate.test_switch_reaches_server_value(Low,Nexus 4)
ERROR: unity8.indicators.tests.test_action_latency.TestServerValueUpdate.test_switch_reaches_server_value(Medium,Nexus 4)
ERROR: unity8.indicators.tests.test_action_latency.TestServerValueUpdate.test_switch_reaches_server_value(High,Nexus 4)
ERROR: unity8.shell.tests.test_helpers.DashHelperTestCase.test_open_applications_scope(Nexus 4)

* Did you make sure that the branch does not contain spurious tags?
Yes, all clean

review: Approve

« Back to merge proposal