* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.
Ran on mako and everything looked ok. My krillin is dead atm.
Checked the SDK-test by injecting a wrong import using 1.2 and it was correctly caught by the script.
* Did CI run pass? If not, please explain why.
No, because multiple autopilot errors occurred due to unity8 process probably crashing -> "psutil.NoSuchProcess: no process found with pid..."
Code looks ok.
* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.
Ran on mako and everything looked ok. My krillin is dead atm.
Checked the SDK-test by injecting a wrong import using 1.2 and it was correctly caught by the script.
* Did CI run pass? If not, please explain why. NoSuchProcess: no process found with pid..."
No, because multiple autopilot errors occurred due to unity8 process probably crashing -> "psutil.
ERROR: unity8. greeter. tests.test_ args.GreeterArg sTest.test_ shell_mode shell.tests. test_helpers. DashHelperTestC ase.test_ open_scope_ to_the_ right(Nexus 4) indicators. tests.test_ display_ indicator. DisplayIndicato rTestCase. test_indicator_ icon_must_ not_be_ visible_ after_rotation_ unlocked( Nexus 4) shell.tests. test_helpers. GenericScopeVie wHelperTestCase .test_open_ preview( Nexus 4) indicators. tests.test_ action_ latency. TestServerValue Update. test_switch_ reaches_ server_ value(Low, Nexus 4) indicators. tests.test_ action_ latency. TestServerValue Update. test_switch_ reaches_ server_ value(Medium, Nexus 4) indicators. tests.test_ action_ latency. TestServerValue Update. test_switch_ reaches_ server_ value(High, Nexus 4) shell.tests. test_helpers. DashHelperTestC ase.test_ open_applicatio ns_scope( Nexus 4)
ERROR: unity8.
ERROR: unity8.
ERROR: unity8.
ERROR: unity8.
ERROR: unity8.
ERROR: unity8.
ERROR: unity8.
* Did you make sure that the branch does not contain spurious tags?
Yes, all clean