Code review comment for lp:~aacid/unity8/tabbar_dash

On 28.10.2013 09:31, Albert Astals Cid wrote:
>> Related to above - you should be able to scroll the tab bar by dragging /
>> swiping without tapping first.
>
> That works here :-S

Yeah, must've gotten fixed.

>> After overshooting, the header does not come back to the original position, it
>> stops some 1-2gu up from where it should be.
>
> Hmmmm, you sure this is a bug? I mean, isn't it just that the list is a bit taller than the viewport and so it doesn't come back simply because it doesn't have to? If not can you tell me exactly what you do to repro?

I'm still getting that sometimes, but need to find steps to repro.

>> The header label travels behind the search entry.
>
> Not sure if i understand this

Fixed.

>> When switching to the sides, the header label moves down some 1-2gu from where
>> it should be.
>
> Is this the same thing than in the other 1-2gu comment?

Fixed.

--
Michał (Saviq) Sawicz <email address hidden>
Canonical Services Ltd.