Code review comment for lp:~aacid/unity8/tabbar_dash

> The search entry behaves wrong on wide screens - it should only take the
> *current* label into account when deciding whether to hide up or not.

Fixed

> Related to above - you should be able to scroll the tab bar by dragging /
> swiping without tapping first.

That works here :-S

> The tab bar should be limited to shell.width - textEntry.width so that they
> don't overlap.

Fixed

> The "fat horizontal divider" is always on screen for me.

Fixed

> After overshooting, the header does not come back to the original position, it
> stops some 1-2gu up from where it should be.

Hmmmm, you sure this is a bug? I mean, isn't it just that the list is a bit taller than the viewport and so it doesn't come back simply because it doesn't have to? If not can you tell me exactly what you do to repro?

>
> The header label travels behind the search entry.

Not sure if i understand this

>
> When switching to the sides, the header label moves down some 1-2gu from where
> it should be.

Is this the same thing than in the other 1-2gu comment?