Code review comment for lp:~aacid/unity8/tabbar_dash

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

The search entry behaves wrong on wide screens - it should only take the *current* label into account when deciding whether to hide up or not.

Related to above - you should be able to scroll the tab bar by dragging / swiping without tapping first.

The tab bar should be limited to shell.width - textEntry.width so that they don't overlap.

The "fat horizontal divider" is always on screen for me.

After overshooting, the header does not come back to the original position, it stops some 1-2gu up from where it should be.

The header label travels behind the search entry.

When switching to the sides, the header label moves down some 1-2gu from where it should be.

review: Needs Fixing (functional)

« Back to merge proposal