Code review comment for lp:~aacid/unity8/suspend_screenshoting

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

As mentioned, SessionScreenshoter could use a better name... For one, it could be SessionShotter (note double-t), as it's not shooting the screen, just the session ;). SessionGrabber? We already have a ScreenGrabber!

Generate qmltypes please.

Is the screenshot unloaded if app has a drawn-to surface?

Some clarification about the activity indicator - we do want it to run over either screenshot or splash screen *if* the app is active/focused, just not if it's in the background.

review: Needs Fixing

« Back to merge proposal