Code review comment for lp:~aacid/unity8/shutdown_from_off_screen

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Code looks ok, although I would prefer to move part of the expression to the inner "if", as it refers to the timer that is restarted in there.

I think the outer "if" should only mention the keys, while the inner goes into details, like the timer. This also makes the code more efficient as it won't unnecessarily evaluate the other "ifs" below for power key presses ever.

http://paste.ubuntu.com/12212834/

review: Approve (code)

« Back to merge proposal