Code review comment for lp:~aacid/unity8/showSearchOnSearchQueryChange

Revision history for this message
Michael Zanetti (mzanetti) wrote :

It adds a tiny oddity:
* Go to clickscope
* start a search
* click on App store

=> now, on clicking the back button it first hides the search, and only a second click goes back to the clickscope.

Approving nevertheless as this is really minor and the gain of this merge is much bigger. In case we fix/workaround this oddity I'm fine with that being a separate fix at a later point.

 * Did you perform an exploratory manual test run of the code change and any related functionality?

Yes.

 * Did CI run pass? If not, please explain why.

Not yet, but signs are good :)

review: Approve

« Back to merge proposal