Merge lp:~aacid/unity8/scopeSearchHintText into lp:unity8
Status: | Merged |
---|---|
Approved by: | Michael Zanetti |
Approved revision: | 1085 |
Merged at revision: | 1144 |
Proposed branch: | lp:~aacid/unity8/scopeSearchHintText |
Merge into: | lp:unity8 |
Prerequisite: | lp:~aacid/unity8/scopeActivatePreview |
Diff against target: |
58 lines (+15/-1) 4 files modified
qml/Components/PageHeader.qml (+1/-0) qml/Dash/GenericScopeView.qml (+1/-0) tests/mocks/Unity/fake_scope.cpp (+1/-1) tests/qmltests/Dash/tst_DashContent.qml (+12/-0) |
To merge this branch: | bzr merge lp:~aacid/unity8/scopeSearchHintText |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Michael Zanetti (community) | Approve | ||
Review via email: mp+228655@code.launchpad.net |
This proposal supersedes a proposal from 2014-07-25.
Commit message
Pass the scope search hint up to the search line
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
https:/
No, but there is a crash somewhere in scopes plugin that makes it crash for some scopes and also we have a white on white text problem, so it eihter needs the SDK team to fix the color on SuruDark or the Dash being a separate app so we can not use SuruDark theme
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes, changed hint color of /usr/lib/
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
This is requested by design
I think we could add a simple test here to make sure the value from the scope ends up in the placeholderText.