Code review comment for lp:~aacid/unity8/saveUnneededGetCardCalls
Revision history for this message
| Albert Astals Cid (aacid) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> Instead changing sourceComponent to undefined, can we simply use active
> true/false for the Loader?
No, if you do that the calls to getCardComponent will still be done because sourceComponent will need to be reevaluated, i.e. even if active is false, the assignment to sourceComponent needs to be calculated.
> I'd also ask to add FIXME for Qt 5.4 so we remember to remove once we upgrade
Added