1
=== modified file 'tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml'
2
--- tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml	2015-11-27 08:12:46 +0000
3
+++ tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml	2016-06-23 08:20:54 +0000
4
@@ -1,5 +1,5 @@
5
1
/*
1
/*
7
2
 * Copyright 2014,2015 Canonical Ltd.
2
 * Copyright 2014-2016 Canonical Ltd.
8
3
 *
3
 *
9
4
 * This program is free software; you can redistribute it and/or modify
4
 * This program is free software; you can redistribute it and/or modify
10
5
 * it under the terms of the GNU General Public License as published by
5
 * it under the terms of the GNU General Public License as published by
11
@@ -42,6 +42,8 @@
12
42
        parentFlickable: root
42
        parentFlickable: root
13
43
    }
43
    }
14
44
44
15
45
    property int createdDelegates: 0
16
46
17
45
    Component.onCompleted: {
47
    Component.onCompleted: {
18
46
        for (var i = 0; i < 500; ++i) {
48
        for (var i = 0; i < 500; ++i) {
19
47
            widgetData500.reviews.push({ author: "Some dude", review: "Very cool app" + i });
49
            widgetData500.reviews.push({ author: "Some dude", review: "Very cool app" + i });
20
@@ -49,37 +51,68 @@
21
49
        factory.widgetData = widgetData500;
51
        factory.widgetData = widgetData500;
22
50
    }
52
    }
23
51
53
24
54
    Component {
25
55
        id: countingPreviewRatingSingleDisplayComponent
26
56
        PreviewRatingSingleDisplay {
27
57
            objectName: "reviewItem" + index
28
58
29
59
            anchors { left: parent.left; right: parent.right; }
30
60
31
61
            rating: modelData["rating"] || -1
32
62
            author: modelData["author"] || ""
33
63
            review: modelData["review"] || ""
34
64
            Component.onCompleted: root.createdDelegates++;
35
65
        }
36
66
    }
37
67
38
52
    UT.UnityTestCase {
68
    UT.UnityTestCase {
40
53
        name: "PreviewRatingDisplayTest"
69
        name: "PreviewRatingDisplayCreationRangesTest"
41
54
        when: windowShown
70
        when: windowShown
42
55
71
44
56
        function test_creation_speed() {
72
        function initTestCase() {
45
73
            var lists = findChildsByType(factory, "QQuickListView");
46
74
            compare(lists.length, 1)
47
75
            lists[0].delegate = countingPreviewRatingSingleDisplayComponent;
48
76
        }
49
77
50
78
        function test_check_delegate_creation_range() {
51
79
            // Clear the reviews
52
80
            factory.widgetData = reviewsEmpty;
53
81
            waitForRendering(root);
54
82
55
83
            // Unset parentFlickable this disables the creation range code
56
57
            factory.parentFlickable = null;
84
            factory.parentFlickable = null;
59
58
            factory.widgetData = reviewsEmpty;
85
            root.createdDelegates = 0;
58
59
            waitForRendering(root);
60
60
86
62
61
            var start = new Date().getTime();
87
            // Set the 500 reviews data
63
62
            factory.widgetData = widgetData500;
88
            factory.widgetData = widgetData500;
64
63
            waitForRendering(root);
89
            waitForRendering(root);
68
64
            var end = new Date().getTime();
90
69
65
            var time500 = end - start;
91
            // Check we have created 500 delegates
70
66
92
            compare(root.createdDelegates, 500);
71
93
72
94
            // Check review 499 has been created
73
95
            var reviewItem499 = findChild(factory, "reviewItem499");
74
96
            verify(reviewItem499 !== null);
75
97
76
98
            // Clear the reviews
77
67
            factory.widgetData = reviewsEmpty;
99
            factory.widgetData = reviewsEmpty;
78
68
            waitForRendering(root);
100
            waitForRendering(root);
79
69
101
80
102
            // set parentFlickable to enable the creation ranges code
81
70
            factory.parentFlickable = root;
103
            factory.parentFlickable = root;
83
71
            start = new Date().getTime();
104
            root.createdDelegates = 0;
84
105
85
106
            // Set the 500 reviews data
86
72
            factory.widgetData = widgetData500;
107
            factory.widgetData = widgetData500;
87
73
            waitForRendering(root);
108
            waitForRendering(root);
97
74
            end = new Date().getTime();
109
98
75
            var timeRanges500 = end - start;
110
            // Check we have only created a few delegates
99
76
111
            // For some reason xenial and yaketti we get 16 and on vivid 15 so
100
77
            // Measurements show it's usually like 20 times faster
112
            // settle for <= 20
101
78
            // but we set the range at 8 times fast to make sure it's not an unstable test
113
            expectFailContinue("", "Should not create more than 20 delegates when using ranges");
102
79
            verify(timeRanges500 * 8 < time500);
114
            tryCompareFunction(function() { return root.createdDelegates > 20 }, true);
103
80
        }
115
95
81
96
82
        function test_check_indexes() {
104
83
            // Check that item 499 isn't there on startup but if we scroll down
116
            // Check that item 499 isn't there on startup but if we scroll down
105
84
            // it will be there
117
            // it will be there
106
85
            var reviewItem499 = findChild(factory, "reviewItem499");
118
            var reviewItem499 = findChild(factory, "reviewItem499");
107
@@ -89,6 +122,9 @@
108
89
122
109
90
            var reviewItem499 = findChild(factory, "reviewItem499");
123
            var reviewItem499 = findChild(factory, "reviewItem499");
110
91
            verify(reviewItem499 !== null);
124
            verify(reviewItem499 !== null);
111
125
112
126
            // Check we have created 500 delegates
113
127
            compare(root.createdDelegates, 500);
114
92
        }
128
        }
115
93
    }
129
    }
116
94
}
130
}
Status:	Merged
Approved by:	Michael Zanetti on 2016-06-24
Approved revision:	2494
Merged at revision:	2523
Proposed branch:	lp:~aacid/unity8/rework_tst_PreviewRatingDisplayCreationRanges
Merge into:	lp:unity8
Diff against target:	116 lines (+55/-19) 1 file modified tests/qmltests/Dash/Previews/tst_PreviewRatingDisplayCreationRanges.qml (+55/-19)
To merge this branch:	bzr merge lp:~aacid/unity8/rework_tst_PreviewRatingDisplayCreationRanges
Related bugs:	Link a bug report
Reviewer	Review Type	Date Requested	Status
Michael Zanetti (community)		2016-06-22	Approve on 2016-06-24
Unity8 CI Bot	continuous-integration		Needs Fixing on 2016-06-23
Review via email: mp+298130@code.launchpad.net