Code review comment for lp:~aacid/unity8/photoscopeimprovements

Revision history for this message
Albert Astals Cid (aacid) wrote :

> This introduced a failure in AP:
> unity8.shell.tests.test_emulators.GenericScopeViewEmulatorTestCase.test_open_p
> review

Fixed with the last commit, running the test is considerably slower with this branch than with trunk (105 seconds vs 85 seconds) but using https://code.launchpad.net/~aacid/unity8/moreAsyncDash it goes back to 85 seconds so i think it should not be a problem.

« Back to merge proposal