Merge lp:~aacid/unity8/moreStableDashTestCardIconStyle into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 2597
Merged at revision: 2624
Proposed branch: lp:~aacid/unity8/moreStableDashTestCardIconStyle
Merge into: lp:unity8
Diff against target: 36 lines (+14/-6)
1 file modified
tests/qmltests/Dash/tst_Dash.qml (+14/-6)
To merge this branch: bzr merge lp:~aacid/unity8/moreStableDashTestCardIconStyle
Reviewer Review Type Date Requested Status
Andrea Cimitan (community) Approve
Unity8 CI Bot continuous-integration Needs Fixing
Review via email: mp+303235@code.launchpad.net

Commit message

Dash::test_cardIconStyle change compare into tryCompareFunction

On very slow machines (CI or valgrind) the UCProportionalShape is not created immediately so give it some slack

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2597
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1979/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2598
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1414
    FAILURE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1414/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=yakkety,testname=qmluitests.sh/1414
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2626
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2506
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2506
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2506
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2500/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1979/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
y
 * Did CI run pass? If not, please explain why.
unrelated

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'tests/qmltests/Dash/tst_Dash.qml'
--- tests/qmltests/Dash/tst_Dash.qml 2016-06-21 08:14:56 +0000
+++ tests/qmltests/Dash/tst_Dash.qml 2016-08-18 10:46:51 +0000
@@ -631,18 +631,26 @@
631 tryCompare(dashContent.currentScope, "id", "clickscope");631 tryCompare(dashContent.currentScope, "id", "clickscope");
632632
633 scrollToCategory("dashCategorypredefined");633 scrollToCategory("dashCategorypredefined");
634 var tile = getCategoryDelegate("predefined", 2);634 tryCompareFunction(function() {
635 var proportionalShape = findChildsByType(tile, "UCProportionalShape");635 var tile = getCategoryDelegate("predefined", 2);
636 compare(proportionalShape.length, 1);636 var proportionalShape = findChildsByType(tile, "UCProportionalShape");
637 return proportionalShape.length === 1;
638 },
639 true
640 );
637641
638 dash.setCurrentScope("libertine-scope.ubuntu_libertine-scope");642 dash.setCurrentScope("libertine-scope.ubuntu_libertine-scope");
639 var dashContent = findChild(dash, "dashContent");643 var dashContent = findChild(dash, "dashContent");
640 tryCompare(dashContent.currentScope, "id", "libertine-scope.ubuntu_libertine-scope");644 tryCompare(dashContent.currentScope, "id", "libertine-scope.ubuntu_libertine-scope");
641645
642 scrollToCategory("dashCategory2");646 scrollToCategory("dashCategory2");
643 tile = getCategoryDelegate("2", 2);647 tryCompareFunction(function() {
644 proportionalShape = findChildsByType(tile, "UCProportionalShape");648 var tile = getCategoryDelegate("2", 2);
645 compare(proportionalShape.length, 1);649 var proportionalShape = findChildsByType(tile, "UCProportionalShape");
650 return proportionalShape.length === 1;
651 },
652 true
653 );
646 }654 }
647655
648 function test_tempScopeItemXOnResize()656 function test_tempScopeItemXOnResize()

Subscribers

People subscribed via source and target branches