Merge lp:~aacid/unity8/moreAsyncAudioCard into lp:unity8

[Albert Astals Cid]

Audio Cards: Make some of the image loading async

It improves a bit the smoothness of scrolling the list

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[lp:~aacid/unity8/moreAsyncAudioCard]

2138. By Albert Astals Cid on 2016-01-18

fix test

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2137
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/130/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/130/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2138
http://jenkins.qa.ubuntu.com/job/unity8-ci/7097/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6064
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/512/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1802
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/505
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1697
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1697
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/504
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/503
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4684
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6075
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6075/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26764
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/251/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/510
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/510/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26765

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7097/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2138
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/131/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/131/rebuild

review: Needs Fixing (continuous-integration)

[Albert Astals Cid (aacid)]

I need to merge https://code.launchpad.net/~aacid/unity8/circleForAudioCards/+merge/284747 first

[lp:~aacid/unity8/moreAsyncAudioCard]

2139. By Albert Astals Cid on 2016-02-11

Merge circleForAudioCards

2140. By Albert Astals Cid on 2016-02-11

Require newer sdk

2141. By Albert Astals Cid on 2016-03-10

Merge

2142. By Albert Astals Cid on 2016-03-10

Merge cardCreatorFixedHeaderSizeOptimization

Unmerged revisions

=== modified file 'plugins/Dash/AudioProgressBar.qml'
--- plugins/Dash/AudioProgressBar.qml	2015-12-03 14:44:08 +0000
+++ plugins/Dash/AudioProgressBar.qml	2016-02-11 09:42:14 +0000
@@ -31,6 +31,7 @@
         anchors { left: parent.left; right: parent.right }
         height: units.dp(6)
         source: "graphics/music_progress_bg.png"
+        asynchronous: true
         sourceSize.width: width
         sourceSize.height: height
     }

=== modified file 'plugins/Dash/CardCreator.js'
--- plugins/Dash/CardCreator.js	2016-01-29 11:52:58 +0000
+++ plugins/Dash/CardCreator.js	2016-02-11 09:42:14 +0000
@@ -152,11 +152,21 @@
                                 visible: parent.pressed; \n\
                                 radius: "medium"; \n\
                             } \n\
+                            Rectangle { \n\
+                                color: Qt.rgba(0, 0, 0, 0.5); \n\
+                                anchors.centerIn: parent; \n\
+                                width: parent.width * 0.5; \n\
+                                height: width; \n\
+                                radius: width / 2; \n\
+                            } \n\
                             Icon {  \n\
-                                anchors.fill: parent; \n\
-                                anchors.margins: parent.height > units.gu(5) ? units.gu(2) : 0; \n\
+                                anchors.centerIn: parent; \n\
+                                width: parent.width * 0.3; \n\
+                                height: width; \n\
                                 opacity: 0.9; \n\
                                 name: DashAudioPlayer.playing && AudioUrlComparer.compare(parent.source, DashAudioPlayer.currentSource) ? "media-playback-pause" : "media-playback-start"; \n\
+                                color: "white"; \n\
+                                asynchronous: true; \n\
                             } \n\
                             onClicked: { \n\
                                 if (AudioUrlComparer.compare(source, DashAudioPlayer.currentSource)) { \n\

=== modified file 'tests/plugins/Dash/cardcreator/9.res'
--- tests/plugins/Dash/cardcreator/9.res	2016-01-11 15:40:59 +0000
+++ tests/plugins/Dash/cardcreator/9.res	2016-02-11 09:42:14 +0000
@@ -3,7 +3,7 @@
                 property var components; 
                 property var cardData; 
                 property string artShapeStyle: "inset"; 
-                property string backgroundShapeStyle: "inset";
+                property string backgroundShapeStyle: "inset"; 
                 property real fontScale: 1.0; 
                 property var scopeStyle: null; 
                 property int titleAlignment: Text.AlignLeft; 
@@ -80,12 +80,22 @@
                                 visible: parent.pressed; 
                                 radius: "medium"; 
                             } 
+                            Rectangle { 
+                                color: Qt.rgba(0, 0, 0, 0.5); 
+                                anchors.centerIn: parent; 
+                                width: parent.width * 0.5; 
+                                height: width; 
+                                radius: width / 2; 
+                            } 
                             Icon {  
-                                anchors.fill: parent; 
-                                anchors.margins: parent.height > units.gu(5) ? units.gu(2) : 0; 
+                                anchors.centerIn: parent; 
+                                width: parent.width * 0.3; 
+                                height: width; 
                                 opacity: 0.9; 
                                 name: DashAudioPlayer.playing && AudioUrlComparer.compare(parent.source, DashAudioPlayer.currentSource) ? "media-playback-pause" : "media-playback-start"; 
-                            } 
+                                color: "white"; 
+                                asynchronous: true; 
+                            }
                             onClicked: { 
                                 if (AudioUrlComparer.compare(source, DashAudioPlayer.currentSource)) { 
                                     if (DashAudioPlayer.playing) {