Merge lp:~aacid/unity8/circleForAudioCards into lp:unity8

[Albert Astals Cid]

Visual improvements to the dash audio play cards

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
Yes, patty/grazina approve

[Andrea Cimitan (cimi)]

review: Needs Information

[lp:~aacid/unity8/circleForAudioCards]

2146. By Albert Astals Cid on 2016-02-02

stylistic changes

[Andrea Cimitan (cimi)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
yes
 * Did CI run pass? If not, please explain why.
waiting to top approve
 * Did you make sure that the branch does not contain spurious tags?
yes

review: Approve

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2145
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/252/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/252/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2145
http://jenkins.qa.ubuntu.com/job/unity8-ci/7193/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6295/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/608/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1898
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/601
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1793
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1793
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/600
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/599
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4839/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6306
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6306/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27238
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/322/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/606
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/606/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27237

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7193/rebuild

review: Needs Fixing (continuous-integration)

[Unity8 CI Bot (unity8-ci-bot)]

FAILED: Continuous integration, rev:2146
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/253/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/253/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:2146
http://jenkins.qa.ubuntu.com/job/unity8-ci/7195/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6297
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/610/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1900
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/603
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1795
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1795
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/602
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/601
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4840
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6308
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6308/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27241
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/324/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/608
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/608/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27240

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7195/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'plugins/Dash/CardCreator.js'
--- plugins/Dash/CardCreator.js	2016-01-29 11:52:58 +0000
+++ plugins/Dash/CardCreator.js	2016-02-02 15:20:43 +0000
@@ -152,11 +152,20 @@
                                 visible: parent.pressed; \n\
                                 radius: "medium"; \n\
                             } \n\
+                            Rectangle { \n\
+                                color: Qt.rgba(0, 0, 0, 0.5); \n\
+                                anchors.centerIn: parent; \n\
+                                width: parent.width * 0.5; \n\
+                                height: width; \n\
+                                radius: width / 2; \n\
+                            } \n\
                             Icon {  \n\
-                                anchors.fill: parent; \n\
-                                anchors.margins: parent.height > units.gu(5) ? units.gu(2) : 0; \n\
+                                anchors.centerIn: parent; \n\
+                                width: parent.width * 0.3; \n\
+                                height: width; \n\
                                 opacity: 0.9; \n\
                                 name: DashAudioPlayer.playing && AudioUrlComparer.compare(parent.source, DashAudioPlayer.currentSource) ? "media-playback-pause" : "media-playback-start"; \n\
+                                color: "white"; \n\
                             } \n\
                             onClicked: { \n\
                                 if (AudioUrlComparer.compare(source, DashAudioPlayer.currentSource)) { \n\

=== modified file 'tests/plugins/Dash/cardcreator/9.res'
--- tests/plugins/Dash/cardcreator/9.res	2016-01-11 15:40:59 +0000
+++ tests/plugins/Dash/cardcreator/9.res	2016-02-02 15:20:43 +0000
@@ -3,7 +3,7 @@
                 property var components; 
                 property var cardData; 
                 property string artShapeStyle: "inset"; 
-                property string backgroundShapeStyle: "inset";
+                property string backgroundShapeStyle: "inset"; 
                 property real fontScale: 1.0; 
                 property var scopeStyle: null; 
                 property int titleAlignment: Text.AlignLeft; 
@@ -80,11 +80,20 @@
                                 visible: parent.pressed; 
                                 radius: "medium"; 
                             } 
+                            Rectangle { 
+                                color: Qt.rgba(0, 0, 0, 0.5); 
+                                anchors.centerIn: parent; 
+                                width: parent.width * 0.5; 
+                                height: width; 
+                                radius: width / 2; 
+                            } 
                             Icon {  
-                                anchors.fill: parent; 
-                                anchors.margins: parent.height > units.gu(5) ? units.gu(2) : 0; 
+                                anchors.centerIn: parent; 
+                                width: parent.width * 0.3; 
+                                height: width; 
                                 opacity: 0.9; 
                                 name: DashAudioPlayer.playing && AudioUrlComparer.compare(parent.source, DashAudioPlayer.currentSource) ? "media-playback-pause" : "media-playback-start"; 
+                                color: "white"; 
                             } 
                             onClicked: { 
                                 if (AudioUrlComparer.compare(source, DashAudioPlayer.currentSource)) {