Code review comment for lp:~aacid/unity8/member_to_local_var
Revision history for this message
| Albert Astals Cid (aacid) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
> > > Are you sure about the "notifier" change? The pointer is used in the
> signal
> > > below
> >
> > Which line? I can't find any use of "notifier" in onUDevChanges ? (it also
> > compiles)
>
> Sure but wouldn't the local variable go out of scope, when the ctor is done?
Yes, the variable goes out of scope, but it's not a QScopePointer or "strange" just an object so the QSocketNotifier doesn't get deleted, we just get a wait to reference it.
It could be a memory leak, but since it's a QObject with parent it will get deleted when the QInputDeviceMan