Code review comment for lp:~aacid/unity8/lvwphnoprocessevents

Revision history for this message
Michael Zanetti (mzanetti) wrote :

I wasn't able to reproduce the crash it's supposed to fix. However, I've tested it with this fix too and everything seems to work fine. Doesn't break the thing why the processEvents() was initially introduced.

 * Did you perform an exploratory manual test run of the code change and any related functionality?

Yes.

 * Did CI run pass? If not, please explain why.

No. The qmltests failure should be resolved by now. The previously failed test is now passing here in both, normal run and xvfb-run.

I don't think the AP failure is related. However, seems to be a real failure we should investigate in.

review: Approve

« Back to merge proposal