Merge lp:~aacid/unity8/indicator_keyboard_navigation into lp:unity8

Proposed by Albert Astals Cid
Status: Superseded
Proposed branch: lp:~aacid/unity8/indicator_keyboard_navigation
Merge into: lp:unity8
Prerequisite: lp:~ci-train-bot/unity8/unity8-ubuntu-zesty-2160
Diff against target: 213 lines (+91/-0) (has conflicts)
7 files modified
po/ast.po (+11/-0)
po/fr.po (+11/-0)
po/gl.po (+10/-0)
po/ms.po (+10/-0)
qml/Panel/IndicatorsBar.qml (+1/-0)
qml/Panel/IndicatorsMenu.qml (+14/-0)
tests/qmltests/Panel/tst_IndicatorsMenu.qml (+34/-0)
Text conflict in po/ast.po
Text conflict in po/fr.po
Text conflict in po/gl.po
Text conflict in po/ms.po
To merge this branch: bzr merge lp:~aacid/unity8/indicator_keyboard_navigation
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve
Michael Zanetti (community) Needs Fixing
Review via email: mp+313711@code.launchpad.net

This proposal has been superseded by a proposal from 2017-01-04.

Commit message

Add keyboard navigation for Indicators

Esc closes
Left/Right selects prev/next indicator

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2749
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2761/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3619
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2070
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2070
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3647
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3493
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3493/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3493
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3493/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3493
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3493/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3493
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3493/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3493
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3493/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3493
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3493/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2761/rebuild

review: Approve (continuous-integration)
2750. By Albert Astals Cid

Test left/right/esc keyboard navigation in indicators

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2750
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2768/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3626
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2073
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2073
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3654
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3500/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3500
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3500/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2768/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

In unity7, just clicking on an indicator and then left/right, will already move around. With this branch, after opening the indicators, another "tab" press is required before it starts working. That seems wrong.

review: Needs Fixing
Revision history for this message
Albert Astals Cid (aacid) wrote :

> In unity7, just clicking on an indicator and then left/right, will already
> move around. With this branch, after opening the indicators, another "tab"
> press is required before it starts working. That seems wrong.

Should be fixed now.

2751. By Albert Astals Cid

Make the indicators left/right work just after opening indicators too

Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2751
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2813/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3680
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/2111
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/2111
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3708
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3552
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3552/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3552
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3552/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3552
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3552/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3552
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3552/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3552
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3552/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3552
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3552/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2813/rebuild

review: Approve (continuous-integration)
2752. By Albert Astals Cid

Merge

2753. By Albert Astals Cid

Merge

2754. By Albert Astals Cid

Move test around

Unmerged revisions

2747. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2746. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

2745. By Launchpad Translations on behalf of unity-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'po/ast.po'
--- po/ast.po 2016-12-23 05:00:28 +0000
+++ po/ast.po 2017-01-04 12:10:40 +0000
@@ -7,16 +7,27 @@
7msgstr ""7msgstr ""
8"Project-Id-Version: unity8\n"8"Project-Id-Version: unity8\n"
9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
10<<<<<<< TREE
10"POT-Creation-Date: 2016-12-15 16:17+0000\n"11"POT-Creation-Date: 2016-12-15 16:17+0000\n"
11"PO-Revision-Date: 2016-12-16 02:13+0000\n"12"PO-Revision-Date: 2016-12-16 02:13+0000\n"
12"Last-Translator: enolp <enolp@softastur.org>\n"13"Last-Translator: enolp <enolp@softastur.org>\n"
14=======
15"POT-Creation-Date: 2016-12-07 13:49+0000\n"
16"PO-Revision-Date: 2016-12-16 02:13+0000\n"
17"Last-Translator: enolp <enolp@softastur.org>\n"
18>>>>>>> MERGE-SOURCE
13"Language-Team: Asturian <ast@li.org>\n"19"Language-Team: Asturian <ast@li.org>\n"
14"MIME-Version: 1.0\n"20"MIME-Version: 1.0\n"
15"Content-Type: text/plain; charset=UTF-8\n"21"Content-Type: text/plain; charset=UTF-8\n"
16"Content-Transfer-Encoding: 8bit\n"22"Content-Transfer-Encoding: 8bit\n"
17"Plural-Forms: nplurals=2; plural=n != 1;\n"23"Plural-Forms: nplurals=2; plural=n != 1;\n"
24<<<<<<< TREE
18"X-Launchpad-Export-Date: 2016-12-23 04:58+0000\n"25"X-Launchpad-Export-Date: 2016-12-23 04:58+0000\n"
19"X-Generator: Launchpad (build 18298)\n"26"X-Generator: Launchpad (build 18298)\n"
27=======
28"X-Launchpad-Export-Date: 2016-12-17 05:27+0000\n"
29"X-Generator: Launchpad (build 18298)\n"
30>>>>>>> MERGE-SOURCE
2031
21#: plugins/LightDM/Greeter.cpp:12332#: plugins/LightDM/Greeter.cpp:123
22msgid "Password: "33msgid "Password: "
2334
=== modified file 'po/fr.po'
--- po/fr.po 2016-12-23 05:00:28 +0000
+++ po/fr.po 2017-01-04 12:10:40 +0000
@@ -7,16 +7,27 @@
7msgstr ""7msgstr ""
8"Project-Id-Version: unity\n"8"Project-Id-Version: unity\n"
9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
10<<<<<<< TREE
10"POT-Creation-Date: 2016-12-15 16:17+0000\n"11"POT-Creation-Date: 2016-12-15 16:17+0000\n"
11"PO-Revision-Date: 2016-12-17 14:32+0000\n"12"PO-Revision-Date: 2016-12-17 14:32+0000\n"
12"Last-Translator: Anne017 <anneonyme017@openmailbox.org>\n"13"Last-Translator: Anne017 <anneonyme017@openmailbox.org>\n"
14=======
15"POT-Creation-Date: 2016-12-07 13:49+0000\n"
16"PO-Revision-Date: 2016-12-17 14:32+0000\n"
17"Last-Translator: Anne017 <anneonyme017@openmailbox.org>\n"
18>>>>>>> MERGE-SOURCE
13"Language-Team: French <fr@li.org>\n"19"Language-Team: French <fr@li.org>\n"
14"MIME-Version: 1.0\n"20"MIME-Version: 1.0\n"
15"Content-Type: text/plain; charset=UTF-8\n"21"Content-Type: text/plain; charset=UTF-8\n"
16"Content-Transfer-Encoding: 8bit\n"22"Content-Transfer-Encoding: 8bit\n"
17"Plural-Forms: nplurals=2; plural=n > 1;\n"23"Plural-Forms: nplurals=2; plural=n > 1;\n"
24<<<<<<< TREE
18"X-Launchpad-Export-Date: 2016-12-23 04:59+0000\n"25"X-Launchpad-Export-Date: 2016-12-23 04:59+0000\n"
19"X-Generator: Launchpad (build 18298)\n"26"X-Generator: Launchpad (build 18298)\n"
27=======
28"X-Launchpad-Export-Date: 2016-12-18 05:20+0000\n"
29"X-Generator: Launchpad (build 18298)\n"
30>>>>>>> MERGE-SOURCE
2031
21#: plugins/LightDM/Greeter.cpp:12332#: plugins/LightDM/Greeter.cpp:123
22msgid "Password: "33msgid "Password: "
2334
=== modified file 'po/gl.po'
--- po/gl.po 2016-12-23 05:00:28 +0000
+++ po/gl.po 2017-01-04 12:10:40 +0000
@@ -7,16 +7,26 @@
7msgstr ""7msgstr ""
8"Project-Id-Version: unity\n"8"Project-Id-Version: unity\n"
9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
10<<<<<<< TREE
10"POT-Creation-Date: 2016-12-15 16:17+0000\n"11"POT-Creation-Date: 2016-12-15 16:17+0000\n"
11"PO-Revision-Date: 2016-12-16 00:21+0000\n"12"PO-Revision-Date: 2016-12-16 00:21+0000\n"
13=======
14"POT-Creation-Date: 2016-12-07 13:49+0000\n"
15"PO-Revision-Date: 2016-12-16 00:21+0000\n"
16>>>>>>> MERGE-SOURCE
12"Last-Translator: Marcos Lans <Unknown>\n"17"Last-Translator: Marcos Lans <Unknown>\n"
13"Language-Team: Galician <gl@li.org>\n"18"Language-Team: Galician <gl@li.org>\n"
14"MIME-Version: 1.0\n"19"MIME-Version: 1.0\n"
15"Content-Type: text/plain; charset=UTF-8\n"20"Content-Type: text/plain; charset=UTF-8\n"
16"Content-Transfer-Encoding: 8bit\n"21"Content-Transfer-Encoding: 8bit\n"
17"Plural-Forms: nplurals=2; plural=n != 1;\n"22"Plural-Forms: nplurals=2; plural=n != 1;\n"
23<<<<<<< TREE
18"X-Launchpad-Export-Date: 2016-12-23 04:59+0000\n"24"X-Launchpad-Export-Date: 2016-12-23 04:59+0000\n"
19"X-Generator: Launchpad (build 18298)\n"25"X-Generator: Launchpad (build 18298)\n"
26=======
27"X-Launchpad-Export-Date: 2016-12-17 05:27+0000\n"
28"X-Generator: Launchpad (build 18298)\n"
29>>>>>>> MERGE-SOURCE
2030
21#: plugins/LightDM/Greeter.cpp:12331#: plugins/LightDM/Greeter.cpp:123
22msgid "Password: "32msgid "Password: "
2333
=== modified file 'po/ms.po'
--- po/ms.po 2016-12-23 05:00:28 +0000
+++ po/ms.po 2017-01-04 12:10:40 +0000
@@ -7,16 +7,26 @@
7msgstr ""7msgstr ""
8"Project-Id-Version: unity8\n"8"Project-Id-Version: unity8\n"
9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"9"Report-Msgid-Bugs-To: FULL NAME <EMAIL@ADDRESS>\n"
10<<<<<<< TREE
10"POT-Creation-Date: 2016-12-15 16:17+0000\n"11"POT-Creation-Date: 2016-12-15 16:17+0000\n"
11"PO-Revision-Date: 2016-12-20 14:02+0000\n"12"PO-Revision-Date: 2016-12-20 14:02+0000\n"
13=======
14"POT-Creation-Date: 2016-12-07 13:49+0000\n"
15"PO-Revision-Date: 2016-12-20 14:02+0000\n"
16>>>>>>> MERGE-SOURCE
12"Last-Translator: abuyop <Unknown>\n"17"Last-Translator: abuyop <Unknown>\n"
13"Language-Team: Malay <ms@li.org>\n"18"Language-Team: Malay <ms@li.org>\n"
14"MIME-Version: 1.0\n"19"MIME-Version: 1.0\n"
15"Content-Type: text/plain; charset=UTF-8\n"20"Content-Type: text/plain; charset=UTF-8\n"
16"Content-Transfer-Encoding: 8bit\n"21"Content-Transfer-Encoding: 8bit\n"
17"Plural-Forms: nplurals=2; plural=n != 1;\n"22"Plural-Forms: nplurals=2; plural=n != 1;\n"
23<<<<<<< TREE
18"X-Launchpad-Export-Date: 2016-12-23 04:59+0000\n"24"X-Launchpad-Export-Date: 2016-12-23 04:59+0000\n"
19"X-Generator: Launchpad (build 18298)\n"25"X-Generator: Launchpad (build 18298)\n"
26=======
27"X-Launchpad-Export-Date: 2016-12-21 05:34+0000\n"
28"X-Generator: Launchpad (build 18298)\n"
29>>>>>>> MERGE-SOURCE
2030
21#: plugins/LightDM/Greeter.cpp:12331#: plugins/LightDM/Greeter.cpp:123
22msgid "Password: "32msgid "Password: "
2333
=== modified file 'qml/Panel/IndicatorsBar.qml'
--- qml/Panel/IndicatorsBar.qml 2015-09-02 07:42:27 +0000
+++ qml/Panel/IndicatorsBar.qml 2017-01-04 12:10:40 +0000
@@ -43,6 +43,7 @@
43 row.resetCurrentItem();43 row.resetCurrentItem();
44 }44 }
45 row.setCurrentItemIndex(index);45 row.setCurrentItemIndex(index);
46 d.alignIndicators();
46 }47 }
4748
48 function addScrollOffset(scrollAmmout) {49 function addScrollOffset(scrollAmmout) {
4950
=== modified file 'qml/Panel/IndicatorsMenu.qml'
--- qml/Panel/IndicatorsMenu.qml 2016-06-15 14:36:15 +0000
+++ qml/Panel/IndicatorsMenu.qml 2017-01-04 12:10:40 +0000
@@ -131,6 +131,19 @@
131 color: panelColor131 color: panelColor
132 }132 }
133133
134 Keys.onPressed: {
135 if (event.key === Qt.Key_Left) {
136 bar.setCurrentItemIndex(bar.currentItemIndex - 1);
137 event.accepted = true;
138 } else if (event.key === Qt.Key_Right) {
139 bar.setCurrentItemIndex(bar.currentItemIndex + 1);
140 event.accepted = true;
141 } else if (event.key === Qt.Key_Escape) {
142 root.hide();
143 event.accepted = true;
144 }
145 }
146
134 IndicatorsBar {147 IndicatorsBar {
135 id: bar148 id: bar
136 objectName: "indicatorsBar"149 objectName: "indicatorsBar"
@@ -356,6 +369,7 @@
356 State {369 State {
357 name: "commit"370 name: "commit"
358 extend: "locked"371 extend: "locked"
372 PropertyChanges { target: root; focus: true }
359 PropertyChanges { target: bar; interactive: true }373 PropertyChanges { target: bar; interactive: true }
360 PropertyChanges {374 PropertyChanges {
361 target: d;375 target: d;
362376
=== modified file 'tests/qmltests/Panel/tst_IndicatorsMenu.qml'
--- tests/qmltests/Panel/tst_IndicatorsMenu.qml 2016-09-24 04:31:04 +0000
+++ tests/qmltests/Panel/tst_IndicatorsMenu.qml 2017-01-04 12:10:40 +0000
@@ -303,5 +303,39 @@
303 indicatorsMenu.available = true;303 indicatorsMenu.available = true;
304 indicatorsMenu.hide();304 indicatorsMenu.hide();
305 }305 }
306
307 function test_keyboardNavigation_data() {
308 return [
309 {tag: "tab to start", doTab: false},
310 {tag: "no tab to start", doTab: true}
311 ]
312 }
313
314 function test_keyboardNavigation(data) {
315 var indicatorsBar = findChild(indicatorsMenu, "indicatorsBar");
316
317 indicatorsMenu.show();
318 indicatorsBar.setCurrentItemIndex(0);
319 tryCompare(indicatorsMenu, "fullyOpened", true);
320
321 if (data.doTab) {
322 keyClick(Qt.Key_Tab);
323 }
324
325 keyClick(Qt.Key_Right);
326 tryCompare(indicatorsBar, "currentItemIndex", 1);
327
328 keyClick(Qt.Key_Right);
329 tryCompare(indicatorsBar, "currentItemIndex", 2);
330
331 keyClick(Qt.Key_Left);
332 tryCompare(indicatorsBar, "currentItemIndex", 1);
333
334 keyClick(Qt.Key_Left);
335 tryCompare(indicatorsBar, "currentItemIndex", 0);
336
337 keyClick(Qt.Key_Escape);
338 tryCompare(indicatorsMenu, "fullyClosed", true);
339 }
306 }340 }
307}341}

Subscribers

People subscribed via source and target branches