Code review comment for lp:~aacid/unity8/dynamic_specialized_cards

Revision history for this message
Albert Astals Cid (aacid) wrote :

> 192 +var headerRowCode = 'Row { \n\
>
> Can you please add a comment on top of those describing what %1, %2... are
> supposed to do.
>
> ===
>
> I also find it a bit confusing that sometimes its like this:
>
> propName: %1 \n
>
> and sometimes like this:
>
> %1 \n
>
> Would it be better like this?
>
> anchors: %1 \n
>
> so we could fill it with .arg("{left: foo; right: bar}"); It would restrict it
> a bit more what can be injected to a narrower defined set.

Done both

« Back to merge proposal