Unity 8

Code review comment for lp:~aacid/unity8/dynamic_specialized_cards

  1. dynamic_specialized_cards
  2. Merge into trunk
Revision history for this message
Michael Zanetti (mzanetti) wrote :

running this on the phone, being in the music scope and copying music to the device using adb push I get nasty flickering and those messages:

file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
file:///home/phablet/shell/builddir/plugins/Dash/createCardComponent:1:130: QML AbstractButton: Binding loop detected for property "headerHeight"
ASSERT: "!isEmpty()" in file /usr/include/qt5/QtCore/qlist.h, line 287
()

After a while it crashed.. I'm not sure if it the crash is really related to this branch. but can we investigate and get rid of the binding loops if possible?

The flickering is quite disturbing, most likely because everything is async now. can we perhaps trick with painting a layer of the old state until the new one has been built up?

« Back to merge proposal