Code review comment for lp:~aacid/unity8/doNotCloseLauncherContainsMouse

Revision history for this message
Albert Astals Cid (aacid) wrote :

> I wonder why you need the flag (ignoreHideIfMouseOverLauncher)? Isn't itemUnderMouse() enough?

No, because sometimes we do not want to ignore the hide, i.e. the call to hide(); from onLockedVisibleChanged

> And as for a test, try adding some delay to the mouseMove() test function
That won't help, i investigated more and QQuickItem::isUnderMouse uses QGuiApplicationPrivate::lastCursorPosition that is not set by the qml test functions (it bypasses that level and goes directly to the item).

I fried fixing the qml test functions but it was a big mess and i gave up, the other option would be somehow usng the qtcore tets functions that actually update properly the QGuiApplicationPrivate::lastCursorPosition value.

« Back to merge proposal