Code review comment for lp:~aacid/unity8/decodeAudioURIs

Revision history for this message
James Henstridge (jamesh) wrote :

> "The result won't necessarily be a valid URI"
>
> Why not?

Sorry, missed your question. Looking at the docs, it seems it won't decode certain reserved characters, so it probably won't create an invalid URI.

The result won't necessarily refer to the same file though, which is a problem. For example:

  >> decodeURI("file:///hello%253f.mp3")
  "file:///hello%3f.mp3"

Here the input refers to a file "hello%3f.mp3", and the result to a file "hello?.mp3".

« Back to merge proposal