Code review comment for lp:~aacid/unity8/decodeAudioURIs

Revision history for this message
James Henstridge (jamesh) wrote :

Is decodeURI really the right choice here? The result won't necessarily be a valid URI, which the property would be expecting.

As I understand it, we've got two pieces of code generating URLs for files on disk that choose to escape different sets of characters. Just decoding the escapes in URLs from one source won't necessarily get all equivalent URLs to match. Instead, it should probably be using a normalisation transform as discussed in https://tools.ietf.org/html/rfc3986#section-6

« Back to merge proposal