Code review comment for lp:~aacid/unity8/decodeAudioURIs

Revision history for this message
Albert Astals Cid (aacid) wrote :

I'm not sure what you want to test here.

In my opinion the only valid test would be a full stack test that creates a file with [ on the filename, gets the mediascanner to parse it, waits for the music scope to show it, then we send that url to the qt audio player and check the url it says it is playing is the same.

And i don't see how to do that with our test facilities.

Using mocks for any of the steps above basically means that if any of the other actors change their behaviours the test will still work but the real thing will fail, making the test rather useless.

« Back to merge proposal