Code review comment for lp:~aacid/unity8/dash_overview

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

Some functional/visual feedback:

1. the initial delay before the scope starts following your finger is annoying, anything we could do about that?
2. I got into a state where the image for a scope was not cross-faded but replaced in one frame, ideas?

Screenshots in https://drive.google.com/open?id=0B32jwBcbaPloTm5uOXh5ZVdram8
vs. visuals in https://sites.google.com/a/canonical.com/unity8dash/scopes/dash-overview

1.png:
- no bottom edge hint

2.png:
- too small and not colourized search icon [fixed by UITK]
- Store and Done button are not visible enough (should be white?)
- overlays not coloured [lp:~aacid/unity8/implementOverlayColor]
- overlay corners don't line up (could be fixed by the above)
- wrong aspect ratio (should be 0.578947368, could we please find a better value?)
- not enough padding above/below buttons in the bottom bar
- not enough top padding in the overlay

3.png:
- bottom bar too translucent
- wrong images [ssserver]

4.png:
- mascot should be gone [ssserver]

5.png:
- background in Results should be gone [ssserver]
- translucent white bar as category separator [separate fix - needs new dividers]
- scopes in Recommendations have wrong card layout [ssserver]

review: Needs Fixing (functional/design)

« Back to merge proposal