Code review comment for lp:~aacid/unity8/closeMenuBarItemGaps

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

"""
horizontalCenter: !visualItem.isFirstItem ? parent.horizontalCenter : undefined
left: visualItem.isFirstItem ? parent.left : undefined
"""

This got me confused for a bit until I realized the two ifs are different. One is "not first" and the other is "is first". For consistency and readability would be nice if the two matched.

Not a blocker, though

« Back to merge proposal