Code review comment for lp:~aacid/unity8/categoryDelegateRangeFixOvershootDetection

Revision history for this message
Albert Astals Cid (aacid) wrote :

So it is not hard in principle but it's actually hard in practice, if we want to exercise the new condition of taking into account originY we need a way to modify it, but this only happens internally when modifying adding items on the list, but unfortunately at the moment our tests for GenericScopeView depend on a static fake Scopes that returns the same scope list all the time.

I agree it would be great having a test for this, but at the moment modifying the test to do that is probably too much work.

« Back to merge proposal