Merge lp:~aacid/unity8/bug1365929 into lp:unity8

Proposed by Albert Astals Cid
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 1264
Merged at revision: 1279
Proposed branch: lp:~aacid/unity8/bug1365929
Merge into: lp:unity8
Diff against target: 21 lines (+2/-2)
1 file modified
qml/Dash/PageHeader.qml (+2/-2)
To merge this branch: bzr merge lp:~aacid/unity8/bug1365929
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Andrea Cimitan (community) Approve
Review via email: mp+234795@code.launchpad.net

Commit message

Pixel pushing in the dash header

Description of the change

 * Are there any related MPs required for this MP to build/function as expected?
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * Did you make sure that your branch does not contain spurious tags?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
This change is wanted by design

To post a comment you must log in.
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
yes
 * Did CI run pass? If not, please explain why.
not run yet

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Dash/PageHeader.qml'
--- qml/Dash/PageHeader.qml 2014-09-08 14:15:28 +0000
+++ qml/Dash/PageHeader.qml 2014-09-16 10:52:48 +0000
@@ -132,7 +132,7 @@
132 objectName: "headerContainer"132 objectName: "headerContainer"
133 clip: contentY < height133 clip: contentY < height
134 anchors { left: parent.left; top: parent.top; right: parent.right }134 anchors { left: parent.left; top: parent.top; right: parent.right }
135 height: units.gu(6.5)135 height: units.gu(7)
136 contentHeight: headersColumn.height136 contentHeight: headersColumn.height
137 interactive: false137 interactive: false
138 contentY: showSearch ? 0 : height138 contentY: showSearch ? 0 : height
@@ -287,7 +287,7 @@
287 id: imageComponent287 id: imageComponent
288288
289 Item {289 Item {
290 anchors { fill: parent; topMargin: units.gu(1); bottomMargin: units.gu(1) }290 anchors { fill: parent; topMargin: units.gu(1.5); bottomMargin: units.gu(1.5) }
291 clip: true291 clip: true
292 Image {292 Image {
293 objectName: "titleImage"293 objectName: "titleImage"

Subscribers

People subscribed via source and target branches