Merge lp:~aacid/unity8/attributeAspectRatio into lp:unity8
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Andrea Cimitan |
Approved revision: | 1600 |
Merged at revision: | 1625 |
Proposed branch: | lp:~aacid/unity8/attributeAspectRatio |
Merge into: | lp:unity8 |
Diff against target: |
58 lines (+8/-0) 4 files modified
plugins/Dash/CardAttributes.qml (+2/-0) plugins/Dash/CardCreator.js (+3/-0) qml/Panel/IndicatorItem.qml (+2/-0) tests/plugins/Dash/cardcreator/6.res (+1/-0) |
To merge this branch: | bzr merge lp:~aacid/unity8/attributeAspectRatio |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Zanetti (community) | Abstain | ||
Andrea Cimitan (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Michał Sawicz | visual | Approve | |
Review via email: mp+249472@code.launchpad.net |
Commit message
Preserve the aspect ratio for the card attribute images
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
FAILED: Continuous integration, rev:1598 jenkins. qa.ubuntu. com/job/ unity8- ci/5302/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 1322 jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- vivid/466 jenkins. qa.ubuntu. com/job/ unity8- vivid-amd64- ci/467 jenkins. qa.ubuntu. com/job/ unity8- vivid-i386- ci/467 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-mako/ 1168 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1320 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 1320/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 18006
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/5302/ rebuild
http://