Code review comment for lp:~aacid/unity8/action_preview_widget

Revision history for this message
Michał Sawicz (saviq) wrote :

74 + gradient: UbuntuColors.orangeGradient

No gradient, please - use color: Theme.palette.selected.foreground

=====

76 + width: parent.width

86 + width: parent.width

I'd use anchors, but your call.

=====

129 +/*! This preview widget shows a either one button, two buttons or one button

"shows either"

=====

137 + implicitHeight: row.height
138 + implicitWidth: row.width

Please make it height:, and drop the implicitWidth I think?

=====

158 + item.width = Qt.binding(function() { return (root.width - units.gu(1)) / 2; });

Just make Loader.width ↑, the loaded item will be sized to that.

review: Needs Fixing

« Back to merge proposal