Merge lp:~aacid/unity/remove_qsortfilterproxymodelqml_get into lp:unity/phablet
Proposed by
Albert Astals Cid
Status: | Merged |
---|---|
Approved by: | Michał Sawicz |
Approved revision: | no longer in the source branch. |
Merged at revision: | 666 |
Proposed branch: | lp:~aacid/unity/remove_qsortfilterproxymodelqml_get |
Merge into: | lp:unity/phablet |
Diff against target: |
181 lines (+23/-48) 7 files modified
Dash/Dash.qml (+0/-16) Dash/DashHome.qml (+3/-4) Dash/DashVideos.qml (+13/-5) Dash/Video/VideoPreview.qml (+3/-3) Dash/Video/VideosFilterGrid.qml (+4/-2) plugins/Utils/qsortfilterproxymodelqml.cpp (+0/-17) plugins/Utils/qsortfilterproxymodelqml.h (+0/-1) |
To merge this branch: | bzr merge lp:~aacid/unity/remove_qsortfilterproxymodelqml_get |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michał Sawicz | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+162955@code.launchpad.net |
Commit message
Remove ::get() in qsortfilterprox
Using ::get() means that all the data of the model for a given row is obtained which in most of the cases is unnecessary and in some could mean getting expensive data. This data should be somewhere in the QML already so we should use that and not re-query it again
Description of the change
The new if in DashVideos.qml is a bit ugly, but if we don't want that it'll require a bit of surgery at the Carousel level, that given that we plan to use the Listview'ed one "soon" i'd prefer not to do at the moment.
To post a comment you must log in.
FAILED: Continuous integration, rev:663 jenkins. qa.ubuntu. com/job/ unity-phablet- ci/868/ s-jenkins: 8080/job/ unity-phablet- qmluitests/ 794 jenkins. qa.ubuntu. com/job/ unity-phablet- raring- armhf-ci/ 744 jenkins. qa.ubuntu. com/job/ unity-phablet- raring- armhf-ci/ 744/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-phablet- raring- i386-ci/ 748
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-phablet- ci/868/ rebuild
http://