Code review comment for lp:~aacid/unity/hud-result-highlighting

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

19 + for (var i = 0; i < highlights.length; i += 2) {

Even though you have a preceding "if" checking for a even-numbered length, I think it would be safer if you had it like that instead:
    for (var i = 0; (i + 1) < highlights.length; i += 2) {
or
    for (var i = 0; i < highlights.length - 1; i += 2) {

« Back to merge proposal