Code review comment for lp:~aacid/unity-mir/waitforme

Revision history for this message
Gerry Boland (gerboland) wrote :

This tests strangely: sometimes Ctrl+C works immediately, sometimes only twice, and sometimes never. (note all tests done while screen active).

For example, if I wait for the greeter to appear, Ctrl+C works fine.
But if I hit Ctrl+C before that, I get a crash, sometimes with this:

pure virtual method called
terminate called without an active exception
Aborted (core dumped)

My theory on a cleaner fix is to not use run_mir at all, but copy most of run_mir's contents - just the threas start & stop bits, so leaving out the signal listening callback.

Then Qt should get the stop signal, do it's cleanup and exec() returns, and after that can stop all Mir's threads. It's a just a theory though.

This does improve the situation a lot. But can you try the above suggestion and let me know? If it doesn't work, I'll accept this.

« Back to merge proposal