Merge lp:~aacid/unity-mir/fix_qmir_server_app_check into lp:unity-mir

Proposed by Albert Astals Cid
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 41
Merged at revision: 41
Proposed branch: lp:~aacid/unity-mir/fix_qmir_server_app_check
Merge into: lp:unity-mir
Diff against target: 32 lines (+4/-2)
2 files modified
src/modules/Unity/ApplicationManager/application_manager.cpp (+2/-1)
src/modules/Unity/SurfaceManager/mirsurfacemanager.cpp (+2/-1)
To merge this branch: bzr merge lp:~aacid/unity-mir/fix_qmir_server_app_check
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Gerry Boland (community) Approve
Review via email: mp+180822@code.launchpad.net

Commit message

Fix QMirServerApplication check

To post a comment you must log in.
40. By Albert Astals Cid

Fix QMirServerApplication check

41. By Albert Astals Cid

Fix static->dynamic cast here too

Revision history for this message
Gerry Boland (gerboland) wrote :

LGTM, waiting for Jenkins

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/modules/Unity/ApplicationManager/application_manager.cpp'
--- src/modules/Unity/ApplicationManager/application_manager.cpp 2013-08-15 18:10:19 +0000
+++ src/modules/Unity/ApplicationManager/application_manager.cpp 2013-08-19 10:10:25 +0000
@@ -50,10 +50,11 @@
50{50{
51 DLOG("ApplicationManager::ApplicationManager (this=%p)", this);51 DLOG("ApplicationManager::ApplicationManager (this=%p)", this);
5252
53 QMirServerApplication* mirServerApplication = static_cast<QMirServerApplication*>(QCoreApplication::instance());53 QMirServerApplication* mirServerApplication = dynamic_cast<QMirServerApplication*>(QCoreApplication::instance());
54 if (mirServerApplication == NULL) {54 if (mirServerApplication == NULL) {
55 LOG("Need to use QMirServerApplication");55 LOG("Need to use QMirServerApplication");
56 QCoreApplication::quit();56 QCoreApplication::quit();
57 return;
57 }58 }
58 m_mirServer = mirServerApplication->server();59 m_mirServer = mirServerApplication->server();
5960
6061
=== modified file 'src/modules/Unity/SurfaceManager/mirsurfacemanager.cpp'
--- src/modules/Unity/SurfaceManager/mirsurfacemanager.cpp 2013-08-09 13:16:13 +0000
+++ src/modules/Unity/SurfaceManager/mirsurfacemanager.cpp 2013-08-19 10:10:25 +0000
@@ -47,10 +47,11 @@
47{47{
48 DLOG("MirSurfaceManager::MirSurfaceManager (this=%p)", this);48 DLOG("MirSurfaceManager::MirSurfaceManager (this=%p)", this);
4949
50 QMirServerApplication* mirServerApplication = static_cast<QMirServerApplication*>(QCoreApplication::instance());50 QMirServerApplication* mirServerApplication = dynamic_cast<QMirServerApplication*>(QCoreApplication::instance());
51 if (mirServerApplication == NULL) {51 if (mirServerApplication == NULL) {
52 LOG("Need to use QMirServerApplication");52 LOG("Need to use QMirServerApplication");
53 QCoreApplication::quit();53 QCoreApplication::quit();
54 return;
54 }55 }
55 m_mirServer = mirServerApplication->server();56 m_mirServer = mirServerApplication->server();
5657

Subscribers

People subscribed via source and target branches