Merge lp:~aacid/unity-greeter/unsupported_servers into lp:unity-greeter

Proposed by Albert Astals Cid
Status: Merged
Merged at revision: 553
Proposed branch: lp:~aacid/unity-greeter/unsupported_servers
Merge into: lp:unity-greeter
Diff against target: 96 lines (+49/-2)
2 files modified
src/greeter-list.vala (+1/-1)
src/user-list.vala (+48/-1)
To merge this branch: bzr merge lp:~aacid/unity-greeter/unsupported_servers
Reviewer Review Type Date Requested Status
Unity Greeter Development Team Pending
Review via email: mp+122085@code.launchpad.net

Description of the change

Show message + disable input for servers we don't support

To post a comment you must log in.
551. By Albert Astals Cid

introduce a different non supported server so we can test the combos

552. By Albert Astals Cid

unchange this string

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/greeter-list.vala'
--- src/greeter-list.vala 2012-08-27 22:30:33 +0000
+++ src/greeter-list.vala 2012-08-30 15:36:19 +0000
@@ -275,7 +275,7 @@
275 focus_prompt ();275 focus_prompt ();
276 }276 }
277277
278 public void focus_prompt ()278 public virtual void focus_prompt ()
279 {279 {
280 selected_entry.sensitive = true;280 selected_entry.sensitive = true;
281 selected_entry.grab_focus ();281 selected_entry.grab_focus ();
282282
=== modified file 'src/user-list.vala'
--- src/user-list.vala 2012-08-30 13:01:54 +0000
+++ src/user-list.vala 2012-08-30 15:36:19 +0000
@@ -589,6 +589,14 @@
589 {589 {
590 if (remote_server.url == url)590 if (remote_server.url == url)
591 {591 {
592 if (selected_entry.id.has_prefix ("*remote_login"))
593 {
594 if (!is_supported_remote_session (remote_server.type))
595 {
596 show_message (_("Server type not supported."), true);
597 }
598 }
599
592 var fields = new List<RemoteServerField?> ();600 var fields = new List<RemoteServerField?> ();
593 foreach (var field in remote_server.fields)601 foreach (var field in remote_server.fields)
594 fields.append (field);602 fields.append (field);
@@ -705,6 +713,27 @@
705 }713 }
706 }714 }
707715
716 public override void focus_prompt ()
717 {
718 if (selected_entry.id.has_prefix ("*remote_login"))
719 {
720 var url = url_from_remote_loding_server_list_name(selected_entry.id);
721 foreach (var remote_server in remote_login_server_list)
722 {
723 if (remote_server.url == url)
724 {
725 if (!is_supported_remote_session (remote_server.type))
726 {
727 selected_entry.sensitive = false;
728 return;
729 }
730 }
731 }
732 }
733
734 base.focus_prompt ();
735 }
736
708 public override void show_authenticated (bool successful = true)737 public override void show_authenticated (bool successful = true)
709 {738 {
710 if (successful)739 if (successful)
@@ -826,6 +855,9 @@
826855
827 private bool is_supported_remote_session (string session_internal_name)856 private bool is_supported_remote_session (string session_internal_name)
828 {857 {
858 if (UnityGreeter.test_mode)
859 return session_internal_name == "rdp";
860
829 var found = false;861 var found = false;
830#if HAVE_REMOTE_LIGHTDM862#if HAVE_REMOTE_LIGHTDM
831 foreach (var session in LightDM.get_remote_sessions ())863 foreach (var session in LightDM.get_remote_sessions ())
@@ -1166,10 +1198,25 @@
11661198
1167 remote_server3.fields = {field31, field32, field33};1199 remote_server3.fields = {field31, field32, field33};
11681200
1169 server_list.resize (3);1201 RemoteServer remote_server4 = RemoteServer ();
1202 remote_server4.type = "notsupported";
1203 remote_server4.name = "Not supported server";
1204 remote_server4.url = "http://notsupportedserver.com";
1205 remote_server4.fields = {};
1206 RemoteServerField field41 = RemoteServerField ();
1207 field41.type = "username";
1208 RemoteServerField field42 = RemoteServerField ();
1209 field42.type = "password";
1210 RemoteServerField field43 = RemoteServerField ();
1211 field43.type = "domain";
1212
1213 remote_server4.fields = {field41, field42, field43};
1214
1215 server_list.resize (4);
1170 server_list[0] = remote_server1;1216 server_list[0] = remote_server1;
1171 server_list[1] = remote_server2;1217 server_list[1] = remote_server2;
1172 server_list[2] = remote_server3;1218 server_list[2] = remote_server3;
1219 server_list[3] = remote_server4;
1173 }1220 }
11741221
1175 private bool test_key_press_cb (Gdk.EventKey event)1222 private bool test_key_press_cb (Gdk.EventKey event)

Subscribers

People subscribed via source and target branches