Merge lp:~aacid/unity-greeter/unsupported_servers into lp:unity-greeter

Proposed by Albert Astals Cid
Status: Merged
Merged at revision: 553
Proposed branch: lp:~aacid/unity-greeter/unsupported_servers
Merge into: lp:unity-greeter
Diff against target: 96 lines (+49/-2)
2 files modified
src/greeter-list.vala (+1/-1)
src/user-list.vala (+48/-1)
To merge this branch: bzr merge lp:~aacid/unity-greeter/unsupported_servers
Reviewer Review Type Date Requested Status
Unity Greeter Development Team Pending
Review via email: mp+122085@code.launchpad.net

Description of the change

Show message + disable input for servers we don't support

To post a comment you must log in.
551. By Albert Astals Cid

introduce a different non supported server so we can test the combos

552. By Albert Astals Cid

unchange this string

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/greeter-list.vala'
2--- src/greeter-list.vala 2012-08-27 22:30:33 +0000
3+++ src/greeter-list.vala 2012-08-30 15:36:19 +0000
4@@ -275,7 +275,7 @@
5 focus_prompt ();
6 }
7
8- public void focus_prompt ()
9+ public virtual void focus_prompt ()
10 {
11 selected_entry.sensitive = true;
12 selected_entry.grab_focus ();
13
14=== modified file 'src/user-list.vala'
15--- src/user-list.vala 2012-08-30 13:01:54 +0000
16+++ src/user-list.vala 2012-08-30 15:36:19 +0000
17@@ -589,6 +589,14 @@
18 {
19 if (remote_server.url == url)
20 {
21+ if (selected_entry.id.has_prefix ("*remote_login"))
22+ {
23+ if (!is_supported_remote_session (remote_server.type))
24+ {
25+ show_message (_("Server type not supported."), true);
26+ }
27+ }
28+
29 var fields = new List<RemoteServerField?> ();
30 foreach (var field in remote_server.fields)
31 fields.append (field);
32@@ -705,6 +713,27 @@
33 }
34 }
35
36+ public override void focus_prompt ()
37+ {
38+ if (selected_entry.id.has_prefix ("*remote_login"))
39+ {
40+ var url = url_from_remote_loding_server_list_name(selected_entry.id);
41+ foreach (var remote_server in remote_login_server_list)
42+ {
43+ if (remote_server.url == url)
44+ {
45+ if (!is_supported_remote_session (remote_server.type))
46+ {
47+ selected_entry.sensitive = false;
48+ return;
49+ }
50+ }
51+ }
52+ }
53+
54+ base.focus_prompt ();
55+ }
56+
57 public override void show_authenticated (bool successful = true)
58 {
59 if (successful)
60@@ -826,6 +855,9 @@
61
62 private bool is_supported_remote_session (string session_internal_name)
63 {
64+ if (UnityGreeter.test_mode)
65+ return session_internal_name == "rdp";
66+
67 var found = false;
68 #if HAVE_REMOTE_LIGHTDM
69 foreach (var session in LightDM.get_remote_sessions ())
70@@ -1166,10 +1198,25 @@
71
72 remote_server3.fields = {field31, field32, field33};
73
74- server_list.resize (3);
75+ RemoteServer remote_server4 = RemoteServer ();
76+ remote_server4.type = "notsupported";
77+ remote_server4.name = "Not supported server";
78+ remote_server4.url = "http://notsupportedserver.com";
79+ remote_server4.fields = {};
80+ RemoteServerField field41 = RemoteServerField ();
81+ field41.type = "username";
82+ RemoteServerField field42 = RemoteServerField ();
83+ field42.type = "password";
84+ RemoteServerField field43 = RemoteServerField ();
85+ field43.type = "domain";
86+
87+ remote_server4.fields = {field41, field42, field43};
88+
89+ server_list.resize (4);
90 server_list[0] = remote_server1;
91 server_list[1] = remote_server2;
92 server_list[2] = remote_server3;
93+ server_list[3] = remote_server4;
94 }
95
96 private bool test_key_press_cb (Gdk.EventKey event)

Subscribers

People subscribed via source and target branches