Merge lp:~aacid/unity-2d/unity-2d-shell_shape_bounding_shape_input into lp:~unity-2d-team/unity-2d/unity-2d-shell

Proposed by Albert Astals Cid
Status: Merged
Approved by: Florian Boucault
Approved revision: 966
Merge reported by: Albert Astals Cid
Merged at revision: not available
Proposed branch: lp:~aacid/unity-2d/unity-2d-shell_shape_bounding_shape_input
Merge into: lp:~unity-2d-team/unity-2d/unity-2d-shell
Diff against target: 21 lines (+3/-2)
1 file modified
libunity-2d-private/src/inputshapemanager.cpp (+3/-2)
To merge this branch: bzr merge lp:~aacid/unity-2d/unity-2d-shell_shape_bounding_shape_input
Reviewer Review Type Date Requested Status
Florian Boucault Pending
Review via email: mp+91815@code.launchpad.net

Description of the change

Use ShapeInput when we are on compositing mode, ShapeBounding on non composited one, improves shadow drawing in the composited case.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'libunity-2d-private/src/inputshapemanager.cpp'
2--- libunity-2d-private/src/inputshapemanager.cpp 2012-02-03 16:20:38 +0000
3+++ libunity-2d-private/src/inputshapemanager.cpp 2012-02-07 12:43:34 +0000
4@@ -5,7 +5,7 @@
5
6 #include "inputshapemanager.h"
7 #include "unity2ddeclarativeview.h"
8-#include "screeninfo.h"
9+#include "desktopinfo.h"
10
11 // X11
12 #include <X11/Xlib.h>
13@@ -39,7 +39,8 @@
14 // pixmap created from the mask bitmap. However for some reason I wasn't able to figure out yet
15 // I get a lot of warnings when calling QBitmap::handle, so for now I'm passing a region as a
16 // workaround.
17- XShapeCombineRegion(QX11Info::display(), m_target->effectiveWinId(), ShapeBounding,
18+ XShapeCombineRegion(QX11Info::display(), m_target->effectiveWinId(),
19+ DesktopInfo::instance()->isCompositingManagerRunning() ? ShapeInput : ShapeBounding,
20 0, 0, QRegion(inputShape).handle(), ShapeSet);
21 }
22

Subscribers

People subscribed via source and target branches