Code review comment for lp:~aacid/unity-2d/unity-2d-shell_rtl

Revision history for this message
Gerry Boland (gerboland) wrote :

Could you please my name from the copyright notices please?

The input_shaping tests needs small fixes:
- please rename input_shaping_tests.rb to input_shaping_common.rb
- please fix the require path to shell/input_shaping_common.rb. It's currently pointing to autohide stuff for the launcher.
- could you also please change
verify_true(10, "The actual shape does not match the expected shape") { identical }
to assert statements? If identical is false, it will wait 10 seconds before throwing a fail.

review: Needs Fixing

« Back to merge proposal