Code review comment for lp:~aacid/unity-2d/unity-2d-shell_rtl

Revision history for this message
Gerry Boland (gerboland) wrote :

Lots of your tests fail for people on MM setups, because the TmpWindow you open at (XDo::XWindow.display_geometry[0] - 10,100) is shoved to the next monitor by Metacity, and so don't overlap the Launcher.

Could you do the maths like in test "Move window positioning to check launcher action" as that one works perfectly.

Also some of your comments don't match what's going on, e.g.:

+ # Open Terminal with position 40x100
+ xid = TmpWindow.open_window_at(XDo::XWindow.display_geometry[0] - 40, 100)

Aside from these things, everything looks good!

review: Needs Fixing

« Back to merge proposal