Merge lp:~aacid/unity-2d/tooltip_mm_rtl into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Paweł Stołowski
Approved revision: 1072
Merged at revision: 1074
Proposed branch: lp:~aacid/unity-2d/tooltip_mm_rtl
Merge into: lp:unity-2d
Diff against target: 50 lines (+16/-2)
3 files modified
libunity-2d-private/src/launchermenu.cpp (+1/-1)
shell/launcher/LauncherList.qml (+9/-1)
tests/manual-tests/launcher.txt (+6/-0)
To merge this branch: bzr merge lp:~aacid/unity-2d/tooltip_mm_rtl
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+102338@code.launchpad.net

Commit message

[Launcher] Fix tile tooltip position on RTL MM setups

Description of the change

Fix launcher tile tooltip position on RTL MM setups
UNBLOCK

To post a comment you must log in.
Revision history for this message
Unity Merger (unity-merger) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Revision history for this message
Unity Merger (unity-merger) wrote :

Attempt to merge into lp:unity-2d failed due to conflicts:

text conflict in tests/manual-tests/launcher.txt

lp:~aacid/unity-2d/tooltip_mm_rtl updated
1072. By Albert Astals Cid

Merge lp:unity-2d

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libunity-2d-private/src/launchermenu.cpp'
--- libunity-2d-private/src/launchermenu.cpp 2012-03-08 19:10:11 +0000
+++ libunity-2d-private/src/launchermenu.cpp 2012-04-19 11:55:24 +0000
@@ -175,7 +175,7 @@
175 m_arrowY = 6;175 m_arrowY = 6;
176176
177 if (QApplication::isRightToLeft()) {177 if (QApplication::isRightToLeft()) {
178 x = QApplication::desktop()->width() - x - sizeHint().width();178 x -= sizeHint().width();
179 }179 }
180180
181 move(x, y - sizeHint().height() / 2 );181 move(x, y - sizeHint().height() / 2 );
182182
=== modified file 'shell/launcher/LauncherList.qml'
--- shell/launcher/LauncherList.qml 2012-04-16 15:26:55 +0000
+++ shell/launcher/LauncherList.qml 2012-04-19 11:55:24 +0000
@@ -163,7 +163,15 @@
163 list.visibleMenu.hide()163 list.visibleMenu.hide()
164 }164 }
165 list.visibleMenu = item.menu165 list.visibleMenu = item.menu
166 item.menu.show(declarativeView.globalPosition.x + width, declarativeView.globalPosition.y + list.y - list.contentY +166
167 var xPos
168 if (Utils.isLeftToRight()) {
169 xPos = declarativeView.globalPosition.x + width
170 } else {
171 // We need to substract the menu width too, that's done inside show() itself
172 xPos = declarativeView.globalPosition.x + declarativeView.width - width
173 }
174 item.menu.show(xPos, declarativeView.globalPosition.y + list.y - list.contentY +
167 y + height - selectionOutlineSize / 2)175 y + height - selectionOutlineSize / 2)
168 }176 }
169177
170178
=== modified file 'tests/manual-tests/launcher.txt'
--- tests/manual-tests/launcher.txt 2012-04-19 11:17:53 +0000
+++ tests/manual-tests/launcher.txt 2012-04-19 11:55:24 +0000
@@ -131,6 +131,12 @@
131Verify that the tile that appears in the launcher has the app icon and not the questionmark icon131Verify that the tile that appears in the launcher has the app icon and not the questionmark icon
132----132----
133133
134 * Have a multimonitor setup
135 * Run unity-2d-shell in RTL
136 * Have launchers in both screens
137
138Verify that the tile tooltips appear in the correct screen
139----
134 * Alt+f1 to show launcher140 * Alt+f1 to show launcher
135 * move down with arrow key141 * move down with arrow key
136 * press enter to start/focus a program (firefox works particulary well due to its red background)142 * press enter to start/focus a program (firefox works particulary well due to its red background)

Subscribers

People subscribed via source and target branches