Merge lp:~aacid/unity-2d/launcher_tile_selection_color into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 1073
Merged at revision: 1073
Proposed branch: lp:~aacid/unity-2d/launcher_tile_selection_color
Merge into: lp:unity-2d
Diff against target: 28 lines (+9/-1)
2 files modified
shell/launcher/LauncherItem.qml (+1/-1)
tests/manual-tests/launcher.txt (+8/-0)
To merge this branch: bzr merge lp:~aacid/unity-2d/launcher_tile_selection_color
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+102548@code.launchpad.net

Commit message

[Launcher] Fix the background of the tile being "highlighted" when it should not

Description of the change

Fix the background of the tile being "highlighted" when it should not
UNBLOCK

To post a comment you must log in.
Revision history for this message
Unity Merger (unity-merger) wrote :

There are additional revisions which have not been approved in review. Please seek review and approval of these new revisions.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'shell/launcher/LauncherItem.qml'
--- shell/launcher/LauncherItem.qml 2012-04-03 15:11:46 +0000
+++ shell/launcher/LauncherItem.qml 2012-04-19 11:20:24 +0000
@@ -202,7 +202,7 @@
202 height: item.tileSize202 height: item.tileSize
203 anchors.centerIn: parent203 anchors.centerIn: parent
204204
205 activeFocus: item.activeFocus205 activeFocus: declarativeView.focus && item.activeFocus
206 backgroundFromIcon: item.backgroundFromIcon206 backgroundFromIcon: item.backgroundFromIcon
207207
208 source: (beHudItem && hudLoader) ? hudLoader.item.appIcon : item.icon208 source: (beHudItem && hudLoader) ? hudLoader.item.appIcon : item.icon
209209
=== modified file 'tests/manual-tests/launcher.txt'
--- tests/manual-tests/launcher.txt 2012-04-17 16:07:36 +0000
+++ tests/manual-tests/launcher.txt 2012-04-19 11:20:24 +0000
@@ -130,3 +130,11 @@
130130
131Verify that the tile that appears in the launcher has the app icon and not the questionmark icon131Verify that the tile that appears in the launcher has the app icon and not the questionmark icon
132----132----
133
134 * Alt+f1 to show launcher
135 * move down with arrow key
136 * press enter to start/focus a program (firefox works particulary well due to its red background)
137 * press Alt+f1 again
138
139Verify that the tile of the program you started (e.g. firefox) does not have the background highlighted
140----

Subscribers

People subscribed via source and target branches