Merge lp:~aacid/unity-2d/launcher_dont_show_ourselves into lp:unity-2d

Proposed by Albert Astals Cid
Status: Merged
Approved by: Gerry Boland
Approved revision: 1103
Merged at revision: 1103
Proposed branch: lp:~aacid/unity-2d/launcher_dont_show_ourselves
Merge into: lp:unity-2d
Diff against target: 28 lines (+10/-0)
2 files modified
libunity-2d-private/src/applicationslist.cpp (+3/-0)
tests/manual-tests/launcher.txt (+7/-0)
To merge this branch: bzr merge lp:~aacid/unity-2d/launcher_dont_show_ourselves
Reviewer Review Type Date Requested Status
Gerry Boland Pending
Review via email: mp+107173@code.launchpad.net

Commit message

[launcher] Do not allow a unity-2d-shell.desktop tile to appear in the launcher

Happens when we get a "Can't unmount device" dialog when the device is busy

Description of the change

Do not show ourselves in the launcher

Happens when we get a "Can't unmount device" dialog when the device is busy

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'libunity-2d-private/src/applicationslist.cpp'
--- libunity-2d-private/src/applicationslist.cpp 2012-04-27 10:27:40 +0000
+++ libunity-2d-private/src/applicationslist.cpp 2012-05-24 08:43:19 +0000
@@ -236,6 +236,9 @@
236 if (!bamf_application->user_visible()) {236 if (!bamf_application->user_visible()) {
237 return;237 return;
238 }238 }
239 if (bamf_application->desktop_file().endsWith("/unity-2d-shell.desktop")) {
240 return;
241 }
239242
240 Application* matchingApplication = NULL;243 Application* matchingApplication = NULL;
241 Application* newApplication = new Application;244 Application* newApplication = new Application;
242245
=== modified file 'tests/manual-tests/launcher.txt'
--- tests/manual-tests/launcher.txt 2012-05-21 13:49:05 +0000
+++ tests/manual-tests/launcher.txt 2012-05-24 08:43:19 +0000
@@ -176,3 +176,10 @@
176176
177Verify the launcher hides177Verify the launcher hides
178----178----
179 * Plug an external device
180 * Make it busy (e.g. go to it in a terminal)
181 * Try to safe eject the device
182 * Verify the volume is busy dialog appears
183
184Verify there is no "Unity 2d Shell" tile in the launcher
185----

Subscribers

People subscribed via source and target branches